[Merge] lp:~jani/goget-ubuntu-touch/local-tarball into lp:goget-ubuntu-touch
Jani Monoses
jani.monoses at canonical.com
Mon Jun 16 19:35:27 UTC 2014
Thanks, I'll update the code.
I used --device-tarball initially and it kept not working and I wanted to rule out some flag parsing shortcoming where matching names until dash or something confuses things (it turned out to be the space - the other MR, and I forgot to revisit, especially since local conveys it being local). But yes, device-tarball is better.
Indeed I am missing a defer close there. I used open so I do not have to have a condition and possibly two syscalls :) without O_TRUNC it should not affect existing files, but create one if it is not there.
--
https://code.launchpad.net/~jani/goget-ubuntu-touch/local-tarball/+merge/221733
Your team Ubuntu Phablet Team is subscribed to branch lp:goget-ubuntu-touch.
More information about the Ubuntu-reviews
mailing list