[Merge] lp:~psusi/ubuntu/utopic/udisks2/fix-standby into lp:ubuntu/udisks2
Martin Pitt
martin.pitt at ubuntu.com
Mon Jun 16 08:22:18 UTC 2014
Review: Approve
Thanks Phillip! I pushed the 0001-Use-internal-pm-check-for-smart-poll.patch upstream with a tiny code formatting fix: http://cgit.freedesktop.org/udisks/commit/?id=10fb36a8d6
The second patch required some more cleanup:
- The format string was wrong, %lud will parse an unsigned followed by a literal 'd'. Fixed.
- fscanf() ought to verify that it could actually read the two values (this detected the error above)
- Changed variable names to underscore separation
- Moved variable declarations to the top of the block.
- I used a statically allocated stat_path like in the rest of the code.
Pushed upstream now: http://cgit.freedesktop.org/udisks/commit/?id=65c901f1
I'd like to get this in via Debian and packaging latest git upstream, so I won't directly merge this MP. But I'll close it anyway, as in some sense it is merged now :-)
Thanks!
--
https://code.launchpad.net/~psusi/ubuntu/utopic/udisks2/fix-standby/+merge/223170
Your team Ubuntu branches is subscribed to branch lp:ubuntu/udisks2.
More information about the Ubuntu-reviews
mailing list