[Merge] lp:~ricmm/platform-api/v2-dynamic-refactor into lp:platform-api

Sebastien Bacher seb128 at ubuntu.com
Wed Jun 11 10:10:29 UTC 2014


Review: Needs Fixing

Some review comments

* libubuntu-platform-hardware-api-dev has an unversioned R/B on libplatform-hardware-api1-dev ... is it supposed to surperseed it? You want to at least version those to the new versio, you might want to add a "Provides" as well if that's a rename (see case 5 on https://wiki.debian.org/PackageTransition)

* same for libubuntu-application-api-doc

* Not sure why you are creating dummy transitionnal packages for all binaries, that's usually needed to make upgrades easier to calculate for packages with reverse depends, it's not likely needed for e.g examples or documentation binaries though...

* 
examples/test_haptic_device.cpp: GPL (v3)
examples/test_location_api.cpp: GPL (v3)
examples/test_multiple_surfaces_event_delivery.cpp: GPL (v3)
examples/test_session_c_api.cpp: GPL (v3)
examples/test_sensors_api.cpp: GPL (v3)
examples/test_c_api.cpp: GPL (v3)
src/ubuntu/hardware/tests/test_alarms_api.cpp: GPL (v3)
src/ubuntu/hardware/tests/test_gps_api.cpp: GPL (v3)

The debian/copyright claims that all sources, out of the android ones, are LGPL ... either those files need to be changed or the copyright needs to be updated

* you versioned some new symbols "2.0.0-0ubuntu1", please either drop the revision or use the replace tag
-- 
https://code.launchpad.net/~ricmm/platform-api/v2-dynamic-refactor/+merge/220721
Your team Ubuntu Phablet Team is subscribed to branch lp:platform-api.



More information about the Ubuntu-reviews mailing list