[Merge] lp:~timchen119/ubuntu/utopic/bluez/lp1035431 into lp:ubuntu/bluez
Tim Chen
tim.chen119 at canonical.com
Wed Jun 11 08:28:01 UTC 2014
@Mathieu
Thanks for the review and bring this up,
the reason behind this inconsistency is because it's how bluez5 doing it and I don't plan to modify too much upstream code when porting, upstream commit 6a394b2c7f19b53b630bef2e865f9bc289d4b75c says it's because D-Bus doesn't have a uint8 type, so they use uint16 instead and upstream still use uint8 internally.
==============================================================
commit 6a394b2c7f19b53b630bef2e865f9bc289d4b75c
Author: Johan Hedberg <johan.hedberg at intel.com>
Date: Tue Sep 4 13:49:58 2012 +0300
agent-api: DisplayPasskey: D-Bus doesn't have a uint8 type
#git-upstream/bluez/src$ grep -C2 -Iir "_t entered" *
agent.c-
agent.c-int agent_display_passkey(struct agent *agent, struct btd_device *device,
agent.c: uint32_t passkey, uint16_t entered)
agent.c-{
agent.c- DBusMessage *message;
--
agent.h-
agent.h-int agent_display_passkey(struct agent *agent, struct btd_device *device,
agent.h: uint32_t passkey, uint16_t entered);
agent.h-
agent.h-int agent_display_pincode(struct agent *agent, struct btd_device *device,
--
device.c-
device.c-int device_notify_passkey(struct btd_device *device, uint32_t passkey,
device.c: uint8_t entered)
device.c-{
device.c- struct authentication_req *auth;
--
device.h- uint8_t confirm_hint);
device.h-int device_notify_passkey(struct btd_device *device, uint32_t passkey,
device.h: uint8_t entered);
device.h-int device_notify_pincode(struct btd_device *device, gboolean secure,
device.h- const char *pincode);
--
https://code.launchpad.net/~timchen119/ubuntu/utopic/bluez/lp1035431/+merge/219626
Your team Ubuntu branches is subscribed to branch lp:ubuntu/bluez.
More information about the Ubuntu-reviews
mailing list