[Merge] lp:~ken-vandine/content-hub/lp1326535 into lp:content-hub

Ken VanDine ken.vandine at canonical.com
Mon Jun 9 20:01:24 UTC 2014


Ken VanDine has proposed merging lp:~ken-vandine/content-hub/lp1326535 into lp:content-hub.

Commit message:
Don't abort downloads that haven't been charged yet when a new transfer
is created. This will leave multiple transfers from downloads which haven't
been charged remain in active_transfers until they have been
charged. (LP: #1326535)

Having multiple downloaded transfers in active_transfers means when the
destination starts or resumes, then all the completed downloads will get charged
which will send multiple signals to the destination.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1326535 in content-hub: "multiple downloads not stored if they are dismissed"
  https://bugs.launchpad.net/content-hub/+bug/1326535

For more details, see:
https://code.launchpad.net/~ken-vandine/content-hub/lp1326535/+merge/222549

Don't abort downloads that haven't been charged yet when a new transfer
is created. This will leave multiple transfers from downloads which haven't
been charged remain in active_transfers until they have been
charged. (LP: #1326535)

Having multiple downloaded transfers in active_transfers means when the
destination starts or resumes, then all the completed downloads will get charged
which will send multiple signals to the destination.
-- 
https://code.launchpad.net/~ken-vandine/content-hub/lp1326535/+merge/222549
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~ken-vandine/content-hub/lp1326535 into lp:content-hub.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 469 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140609/5e1ed741/attachment.diff>


More information about the Ubuntu-reviews mailing list