[Merge] lp:~fginther/phablet-tools/fix-ptr-python3-import-check into lp:phablet-tools

Francis Ginther francis.ginther at canonical.com
Fri Jun 6 18:05:34 UTC 2014


Francis Ginther has proposed merging lp:~fginther/phablet-tools/fix-ptr-python3-import-check into lp:phablet-tools.

Commit message:
In phablet-test-run, check the return code when attempting to import tests with python3 instead of just looking for text output. Log messages generated on import will cause the import check to fail when it should not.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1327325 in phablet-tools (Ubuntu): "phablet-test-run will fail if the python3 import prints something to std"
  https://bugs.launchpad.net/ubuntu/+source/phablet-tools/+bug/1327325

For more details, see:
https://code.launchpad.net/~fginther/phablet-tools/fix-ptr-python3-import-check/+merge/222391

In phablet-test-run, check the return code when attempting to import tests with python3 instead of just looking for text output. Log messages generated on import will cause the import check to fail when it should not.
-- 
https://code.launchpad.net/~fginther/phablet-tools/fix-ptr-python3-import-check/+merge/222391
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~fginther/phablet-tools/fix-ptr-python3-import-check into lp:phablet-tools.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 799 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140606/ee99b0f8/attachment.diff>


More information about the Ubuntu-reviews mailing list