[Merge] lp:~mitya57/ubuntu/utopic/gnome-keyring/3.12.2 into lp:ubuntu/gnome-keyring
Luke Yelavich
luke.yelavich at canonical.com
Fri Jun 6 01:00:46 UTC 2014
Review: Needs Fixing
Thanks for your work. The merge looks good, but a couple of points.
- Since the merge is against an unreleased revision of the Debian package, you may want to consider merging all the changelog entries together into one -0ubuntu1 changelog entry. Looking at the changelog, the version number ordering, even though unreleased looks odd. Having the changelog entries listed in this way will also create more work next time, as there will be more conflicts in the changelog.
- You accidentally reverted the standards version definition, a minor point that I would have fixed if the changelog entries were satisfactory. Please consider eyeballing the diff next time.
--
https://code.launchpad.net/~mitya57/ubuntu/utopic/gnome-keyring/3.12.2/+merge/221489
Your team Ubuntu branches is subscribed to branch lp:ubuntu/gnome-keyring.
More information about the Ubuntu-reviews
mailing list