[Merge] lp:~pete-woods/net-cpp/base64 into lp:net-cpp

Thomas Voß thomas.voss at canonical.com
Thu Jun 5 18:13:56 UTC 2014


Review: Approve

> Indeed, the symbols file is missing most of the stuff I'd expect it to
> contain, e.g. url_escape doesn't appear in it. Maybe it has the wrong name,
> and is being ignored?

Might well be the case, and we can fix that in a follow-up MP. With that: LGTM.
-- 
https://code.launchpad.net/~pete-woods/net-cpp/base64/+merge/222055
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~pete-woods/net-cpp/base64 into lp:net-cpp.



More information about the Ubuntu-reviews mailing list