[Merge] lp:~renatofilho/address-book-app/search into lp:~phablet-team/address-book-app/staging

Renato Araujo Oliveira Filho renato.filho at canonical.com
Thu Jun 5 17:04:27 UTC 2014


> I found a couple of issues:
> 
> 1) there is no way to see the last items in the list view when the osk is
> open. The list view should attach to the osk top.
Fixed on rev. 233

> 
> 2) the search field should have word prediction disabled, otherwise it won't
> trigger the query until the entered text is committed (space or tap in a
> suggested word). Something like this should be enough: inputMethodHints:
> Qt.ImhNoPredictiveText
Fixed on rev. 234

> 
> 3) on the device with a big contact list (+600 contacts) the app crashes when
> you change the search term too fast, it seems to me like the search filter is
> being changed any time you change the search term right away. That means if
> the user types the search term too fast, the app will crash.
I am testing with 1500 contacts, and I can not reproduce the problem. Anyway I update the code
to wait some ms before start search, this will consume less cpu and bayberry.

> 
> 4) I know that the contact list collapse is going away, but if you collapse
> the list and switch to favorites while the list is still collapsing, the app
> crashes too.
Yes this will go away, but this bug is not related with the current branch.


-- 
https://code.launchpad.net/~renatofilho/address-book-app/search/+merge/218883
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/address-book-app/staging.



More information about the Ubuntu-reviews mailing list