[Merge] lp:~mardy/webbrowser-app/fix-cookie-tests into lp:webbrowser-app

Alberto Mardegan alberto.mardegan at canonical.com
Thu Jun 5 13:01:35 UTC 2014


Alberto Mardegan has proposed merging lp:~mardy/webbrowser-app/fix-cookie-tests into lp:webbrowser-app.

Commit message:
Fix the cookies unit tests

Make sure that the dbPath always refers to a file, not a directory.
Make sure that even on fast machines (or machines with a low-accuracy timer) the record timestamps are unique.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~mardy/webbrowser-app/fix-cookie-tests/+merge/222187

Fix the cookies unit tests

Make sure that the dbPath always refers to a file, not a directory.
Make sure that even on fast machines (or machines with a low-accuracy timer) the record timestamps are unique.

This has been already tested by Elleo.
-- 
https://code.launchpad.net/~mardy/webbrowser-app/fix-cookie-tests/+merge/222187
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mardy/webbrowser-app/fix-cookie-tests into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3612 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140605/df7fb783/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list