[Merge] lp:~xnox/ubuntu/utopic/sysvinit/upstart-task into lp:ubuntu/sysvinit

Martin Pitt martin.pitt at ubuntu.com
Thu Jun 5 04:25:45 UTC 2014


Review: Needs Fixing

This updated version looks ok to me as per the discussion above. I'd still like the ^task$ to be extended to allow whitespace (as I suggested in my previous inline diff comments, but they might have drowned). Also, I think this should revert http://launchpadlibrarian.net/176540378/sysvinit_2.88dsf-41ubuntu14_2.88dsf-41ubuntu15.diff.gz at the same time. Finally, I think it makes more sense to fold this into the existing debian/patches/upstart_support.patch instead of yet another patch (but fine for now for experimentation).

I built this branch with CONCURRENCY back to "makefile" so that this has any effect. But now my VM hangs at early shutdown, and also I don't see anything at all during boot (even without "quiet splash"), so something is still wrong here. In which environment did you try this?

Thanks!
-- 
https://code.launchpad.net/~xnox/ubuntu/utopic/sysvinit/upstart-task/+merge/221493
Your team Ubuntu branches is requested to review the proposed merge of lp:~xnox/ubuntu/utopic/sysvinit/upstart-task into lp:ubuntu/sysvinit.



More information about the Ubuntu-reviews mailing list