[Merge] lp:~abreu-alexandre/webbrowser-app/add-ap-tests-for-navigation-and-popup into lp:webbrowser-app

[Olivier Tilloy]

> > The type of the parameter for all those three signals should be 'url', not
> 'string'.
> 
> As I said earlier: yes I agree, but I get dbus runtime error on the AP side
> while trying to marshal the 'url' qml type to the QUrl qt type (unknown to
> dbus), ...

Ok, that makes sense.


> > this looks unsafe and abuse-prone to me, can’t we devise a more secure way
> of enabling tests, that doesn’t involve opening a backdoor in the container?
> 
> It is tricky to do something clean w/ this. Either way the container needs to
> run with some context, I did a few updates that makes it a bit cleaner ...

I like the environment variable approach better. Can we not get rid of the --do-not-filter-url-patterns command line switch and rely only on the presence of the env var? (btw I would also check the value of the env var, if it’s "0" or "false" it should be ignored)
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/add-ap-tests-for-navigation-and-popup/+merge/217811
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~abreu-alexandre/webbrowser-app/add-ap-tests-for-navigation-and-popup into lp:webbrowser-app.