[Merge] lp:~renatofilho/address-book-app/contact-share into lp:~phablet-team/address-book-app/staging

Michael Sheldon mike at mikeasoft.com
Tue Jun 3 10:53:34 UTC 2014


Review: Needs Fixing

Couple of issue, when sharing I'm now getting:

file:///usr/share/address-book-app/imports/ContactShare/ContactSharePage.qml:51: ReferenceError: contactExporter is not defined

And when either exporting to another application or sharing, the exported .vcf file contains *all* contacts, not just the selected/shared ones.

Also as a minor thing the import of Ubuntu.Components.Popups 0.1 in ContactView.qml doesn't seem to be needed any more
-- 
https://code.launchpad.net/~renatofilho/address-book-app/contact-share/+merge/221778
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/address-book-app/staging.



More information about the Ubuntu-reviews mailing list