[Merge] lp:~phablet-team/tone-generator/add-pkging into lp:tone-generator

[Robert Bruce Park]

Review: Needs Fixing

See inline comments.

Diff comments:

> === added directory 'debian'
> === added file 'debian/changelog'
> --- debian/changelog	1970-01-01 00:00:00 +0000
> +++ debian/changelog	2014-07-30 19:57:59 +0000
> @@ -0,0 +1,6 @@
> +tone-generator (1.5.4.bzr2) UNRELEASED; urgency=low

CI Train is going to mangle it into whatever+14.10.20140731-0ubuntu1 anyway, so I don't see any real need for the .bzr# notation. And CI Train will tag the versions to the commits so you'll be able to cross-reference release numbers (from bug reports) to commits in trunk anyway.

> +
> +  [ Martti Piirainen ]
> +  * Initial release. Based on https://github.com/nemomobile/tone-generator
> +
> + -- Tony Espy <espy at canonical.com>  Mon, 28 Jul 2014 08:47:14 +0300
> 
> === added file 'debian/compat'
> --- debian/compat	1970-01-01 00:00:00 +0000
> +++ debian/compat	2014-07-30 19:57:59 +0000
> @@ -0,0 +1,1 @@
> +9
> 
> === added file 'debian/control'
> --- debian/control	1970-01-01 00:00:00 +0000
> +++ debian/control	2014-07-30 19:57:59 +0000
> @@ -0,0 +1,51 @@
> +Source: tone-generator
> +Section: sound
> +Priority: optional
> +Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
> +Build-Depends:
> + debhelper (>= 9),
> + autotools-dev,
> + dh-autoreconf,
> + libtool,
> + libglib2.0-dev,
> + libpulse-dev,
> + libdbus-1-dev,
> + libdbus-glib-1-dev

Missing trailing comma. Try 'wrap-and-sort -a -t' or 'wrap-and-sort -a -s -t' as you prefer.

> +Standards-Version: 3.9.5
> +# If you aren't a member of ~phablet-team but need to upload
> +# packaging changes, just go ahead. ~phablet-team will notice
> +# and sync up the code again.
> +Vcs-Bzr: https://code.launchpad.net/~phablet-team/tone-generator/ubuntu
> +Vcs-Browser: http://bazaar.launchpad.net/~phablet-team/tone-generator/ubuntu
> +
> +Package: tone-generator
> +Architecture: any
> +Depends: ${shlibs:Depends}, ${misc:Depends}, dbus, pulseaudio
> +Recommends: telephony-service
> +Description: Telephony Tone Generator (daemon)
> + tone generator is simple daemon which provides
> + generation of playback tones for DTMF (dialer
> + keypad tones), call progress indication, and
> + other miscellaneous telephony-related tones.
> + .
> + This package includes the core daemon.
> +
> +Package: tone-generator-dbg
> +Section: debug
> +Priority: extra
> +Architecture: any
> +Depends: ${misc:Depends}, tone-generator (= ${binary:Version})
> +Description: Telephony Tone Generator (debugging files)
> + tone generator is simple daemon which provides
> + generation of playback tones for DTMF (dialer
> + keypad tones), call progress indication, and
> + other miscellaneous telephony-related tones.
> +
> +Package: tone-generator-scripts
> +Architecture: all
> +Depends: ${misc:Depends}, tone-generator (>= ${source:Version})
> +Description: Telephony Tone Generator (test scripts)
> + tone generator is simple daemon which provides
> + generation of playback tones for DTMF (dialer
> + keypad tones), call progress indication, and
> + other miscellaneous telephony-related tones.
> 
> === added file 'debian/copyright'
> --- debian/copyright	1970-01-01 00:00:00 +0000
> +++ debian/copyright	2014-07-30 19:57:59 +0000
> @@ -0,0 +1,22 @@
> +Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
> +Source: https://launchpad.net/~phablet-team/tone-generator/ubuntu
> +Comment: This package is a fork of: https://github.com/nemomobile/tone-generator
> +
> +Files: *
> +Copyright: Copyright (C) 2010 Nokia Corporation
> +License: LGPL-2.1
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU Lesser Public License as published by
> + the Free Software Foundation version 2 of the License.
> + .
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU Lesser Public License for more details.
> + .
> + You should have received a copy of the GNU Lesser General Public
> + License along with this library; if not, write to the Free Software
> + Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> + .
> + On Debian systems, the complete text of the GNU Lesser General
> + Public License can be found in `/usr/share/common-licenses/LGPL-2.1'.
> 
> === added file 'debian/rules'
> --- debian/rules	1970-01-01 00:00:00 +0000
> +++ debian/rules	2014-07-30 19:57:59 +0000
> @@ -0,0 +1,17 @@
> +#!/usr/bin/make -f
> +
> +CFLAGS += -Wl,-z,defs,--as-needed
> +
> +%:
> +	dh $@ --parallel --with=autoreconf
> +
> +override_dh_installinit:
> +	dh_installinit --no-restart-on-upgrade
> +
> +override_dh_install:
> +	dh_install --list-missing

Should be --fail-missing

> +
> +override_dh_strip:
> +	dh_strip --dbg-package=tone-generator-dbg
> +
> +
> 
> === added file 'debian/tone-generator-scripts.install'
> --- debian/tone-generator-scripts.install	1970-01-01 00:00:00 +0000
> +++ debian/tone-generator-scripts.install	2014-07-30 19:57:59 +0000
> @@ -0,0 +1,1 @@
> +test/* /usr/share/tone-generator/scripts

Please add missing newline at EOF.

> \ No newline at end of file
> 
> === added file 'debian/tone-generator.conf'
> --- debian/tone-generator.conf	1970-01-01 00:00:00 +0000
> +++ debian/tone-generator.conf	2014-07-30 19:57:59 +0000
> @@ -0,0 +1,14 @@
> +description "Starts the tone-generator service"
> +
> +start on started dbus and xsession SESSION=ubuntu-touch
> +stop on runlevel [06]
> +
> +respawn
> +respawn limit unlimited
> +
> +env DTMF_VOLUME=20
> +env TONE_STANDARD="cept"
> +
> +exec tonegend -s $TONE_STANDARD -b 100 -r 20 --volume-dtmf $DTMF_VOLUME
> +post-stop exec sleep 1
> +
> 
> === added file 'debian/tone-generator.install'
> --- debian/tone-generator.install	1970-01-01 00:00:00 +0000
> +++ debian/tone-generator.install	2014-07-30 19:57:59 +0000
> @@ -0,0 +1,4 @@
> +debian/tmp/usr/bin/tonegend

This line should probably just be 'usr/bin/tonegend', shouldn't it? I've never seen a .install file have lines starting with 'debian/tmp' before, very strange.

> +debian/tone-generator.conf /usr/share/upstart/sessions
> +
> +
> 


-- 
https://code.launchpad.net/~phablet-team/tone-generator/add-pkging/+merge/228936
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/tone-generator/add-pkging.