[Merge] lp:~abreu-alexandre/webbrowser-app/devtools-support into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Jul 30 17:07:24 UTC 2014


Review: Needs Fixing

> 142     +    out << "  --inspector[=PORT] run a remote inspector on a
> specified port or" << REMOTE_INSPECTOR_PORT << "as the default port" << endl;
> 
> 155     +    out << "  --inspector[=PORT]                  run a remote
> inspector on a specified port or" << REMOTE_INSPECTOR_PORT << "as the default
> port" << endl;
> 
> You’re missing whitespaces after "or" and before "as". This is how it looks
> when invoking the app with --help:
> 
>     run a remote inspector on a specified port or9221as the default port

This still needs to be fixed in src/app/webbrowser/webbrowser-app.cpp.
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/devtools-support/+merge/225561
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list