[Merge]lp:~sergiusens/account-polld/twitter_avatar into lp:account-polld

Sergio Schvezov sergio.schvezov at canonical.com
Tue Jul 29 10:21:27 UTC 2014


On martes 29 de julio de 2014 00h'47:50 ART, James Henstridge wrote:
> My main concerns with this are:
>
> 1. there is no cache eviction, so it will continue to grow 
> unchecked.  There is nothing in the push notifications model to 
> tell account-polld when the image isn't needed any more either, 
> so it's not clear how this can be handled reliably.
>
> 2. there is no cache validation, so if new avatar images are 
> served from the same URL we will never notice that change.

I thought of adding this as a next step.

> And if using URIs for icons doesn't work, how exactly will real 
> push notifications provide icons once we have them?

Chipaca told me that the push-helper would do that.

-- 
https://code.launchpad.net/~sergiusens/account-polld/twitter_avatar/+merge/228405
Your team Ubuntu Phablet Team is subscribed to branch lp:account-polld.



More information about the Ubuntu-reviews mailing list