[Merge] lp:~abreu-alexandre/webbrowser-app/devtools-support into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Jul 28 21:18:39 UTC 2014


The rest of the changeset looks ok but I’m wondering whether using an environment variable is the best approach. With QtWebKit we didn’t really have a choice as there was no QML API to expose devtools, the only trigger we could use was the env var.
Here, we could simply set the value of the global context property 'webviewDevtoolsDebugPort' in src/app/browserapplication.cpp, instead of setting the env var there and reading it again in the plugin (disclaimer: not tested, but I think it ought to work). What do you think?
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/devtools-support/+merge/225561
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list