[Merge] lp:~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Jul 28 20:41:12 UTC 2014


In shouldReturnData(), please update the last line to this:

   QVERIFY(!model->data(model->index(0, 0), BookmarksModel::Created + 1).isValid());

(the current unmodified one works by chance because it hardcodes the increment to 3 which is > 1)
-- 
https://code.launchpad.net/~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp/+merge/224117
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list