[Merge] lp:~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Jul 23 07:06:57 UTC 2014


Review: Needs Fixing

132	+        beginInsertRows(QModelIndex(), count, count);

I think this should be beginInsertRows(QModelIndex(), 0, 0) (because the entry is prepended, not appended).
-- 
https://code.launchpad.net/~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp/+merge/224117
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list