[Merge] lp:~canonical-platform-qa/address-book-service/test_dummy_service into lp:address-book-service

Leo Arias leo.arias at canonical.com
Tue Jul 22 22:31:44 UTC 2014


Review: Approve code review

om26er: on SetupEnvironmentVariable, it's not clear that you can also set up some demo data.
I have no idea how to make it clear with code, so a docstring for the class is probably a good idea.
om26er: I like your branch, I love these new testability packages in python.
om26er: who is the other one affected by this? brendan or richard?
I think it would be nice if you request a review from him, so you all agree on the strategy.
-- 
https://code.launchpad.net/~canonical-platform-qa/address-book-service/test_dummy_service/+merge/225846
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~canonical-platform-qa/address-book-service/test_dummy_service into lp:address-book-service.



More information about the Ubuntu-reviews mailing list