[Merge] lp:~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp into lp:webbrowser-app

Ugo Riboni ugo.riboni at canonical.com
Mon Jul 21 16:29:01 UTC 2014


> This implementation, with m_entries and m_orderedEntries, duplicates each
> entry as it is stored separately in a map and in a list. It looks like we
> could get rid of m_entries, and use m_orderedEntries instead (or maybe, for
> efficiency, keep a separate list of URLs for which an entry exists).

I kept a separate QSet of URLs, for faster lookups. The only tradeoff in doing this was the fact the set isn't ordered so that when deleting a bookmark I have to go through the entire m_orderedEntries list but I think it's a good trade off.
-- 
https://code.launchpad.net/~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp/+merge/224117
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/webbrowser-app/webbrowser-app-bookmark-timestamp into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list