[Merge] lp:~mandel/ubuntu-download-manager/better-error-logging into lp:ubuntu-download-manager

Manuel de la Peña manuel.delapena at canonical.com
Mon Jul 21 12:37:41 UTC 2014


Manuel de la Peña has proposed merging lp:~mandel/ubuntu-download-manager/better-error-logging into lp:ubuntu-download-manager with lp:~mandel/ubuntu-download-manager/fix-uploads-timeout as a prerequisite.

Commit message:
Fix bug 1346196 by using human readable strings.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1346196 in ubuntu-download-manager: "QNetworkReply::NetworkErrors is not logged in a human readable way"
  https://bugs.launchpad.net/ubuntu-download-manager/+bug/1346196

For more details, see:
https://code.launchpad.net/~mandel/ubuntu-download-manager/better-error-logging/+merge/227544

The code is duplicated and not present in src/common/public/ubuntu/transfers/system/logger.cpp so that we do not expose QNetwork to the user of the client lib.
-- 
https://code.launchpad.net/~mandel/ubuntu-download-manager/better-error-logging/+merge/227544
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~mandel/ubuntu-download-manager/better-error-logging into lp:ubuntu-download-manager.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 15323 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140721/95e1ce81/attachment.diff>


More information about the Ubuntu-reviews mailing list