[Merge] lp:~jamesh/account-polld/twitter-plugin intolp:account-polld

Sergio Schvezov sergio.schvezov at canonical.com
Mon Jul 21 01:30:52 UTC 2014


On viernes 18 de julio de 2014 08h'49:24 ART, James Henstridge wrote:
> James Henstridge has proposed merging 
> lp:~jamesh/account-polld/twitter-plugin into lp:account-polld.
>
> Commit message:
> Add the Twitter polling plugin.
>
> Requested reviews:
>   Sergio Schvezov (sergiusens)
>
> For more details, see:
> https://code.launchpad.net/~jamesh/account-polld/twitter-plugin/+merge/227313

110	+ // Resolve path relative to Graph API base URL, and add access token
this seems to be a stray comment.

250	+ type user struct {
seems to be missing a gofmt/goimports call

97	+ lastMentionId int64
98	+ lastDirectMessageId int64
just out of curiosity, why are these int64 instead of uint64? Is there a 
chance for negative Ids?

I'll do more thorough review in the morning.

-- 
https://code.launchpad.net/~jamesh/account-polld/twitter-plugin/+merge/227313
Your team Ubuntu Phablet Team is subscribed to branch lp:account-polld.



More information about the Ubuntu-reviews mailing list