[Merge] lp:~phablet-team/ofono/mbpi-nettime-plus-oem-fixes into lp:~phablet-team/ofono/ubuntu

Tony Espy espy at canonical.com
Wed Jul 16 23:08:26 UTC 2014


Tony Espy has proposed merging lp:~phablet-team/ofono/mbpi-nettime-plus-oem-fixes into lp:~phablet-team/ofono/ubuntu.

Commit message:
  * drivers/rilmodem/sim.c: notify on SIM removal (LP: #1332306)
  * unit/rilmodem/test-sim-online: fix serial number check (LP: #1334867)
  * plugins/mtk.c: fix race condition when onlining modem
  * build, drivers/infeonmodem, drivers/rilmodem, gril,
    plugins/infeon.c, plugins/ril.*, unit: add Infeon OEM hooks
  * build, plugins/ubuntu-provision.c, ubuntu-apndb.*: re-named
    provisioning plugin code from android-* to ubuntu-*.  Also removed
    code that queries mobile-broadband-provider-info's db, and finally
    implemented a /custom hook for custom apn dbs (LP: #1315509).


Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1315509 in ofono (Ubuntu): "Support /custom/etc/apns-conf.xml"
  https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1315509
  Bug #1332306 in telephony-service (Ubuntu): "Hot-swapped SIMs should be detected and prompt user to reboot"
  https://bugs.launchpad.net/ubuntu/+source/telephony-service/+bug/1332306
  Bug #1334867 in ofono (Ubuntu): "rilmodem/test-sim-online hard-codes 'Serial' match"
  https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1334867

For more details, see:
https://code.launchpad.net/~phablet-team/ofono/mbpi-nettime-plus-oem-fixes/+merge/227122

This branch includes the following changes and bug fixes:

1. It removes querying of the mobile-broadband-provider-info apn db during GPRS/MMS provisioning.

2. It adds a custom hook to GPRS/MSS provisioning ( see bug #1315509 ).

3. It allows the custom and system apn dbs to be overriden by environment variables ( OFONO_CUSTOM_APNDB_PATH & OFONO_SYSTEM_APNDB_PATH) for test purposes.

4. It adds new OEM hooks which allow enablement of Infeon-based modems.

5. It fixes a race condition with dual-SIM MTK-based modems.

6. The rilmodem driver code now notifies the ofono core when SIM card removal is detected ( see bug #1332306 ).




-- 
https://code.launchpad.net/~phablet-team/ofono/mbpi-nettime-plus-oem-fixes/+merge/227122
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/ofono/mbpi-nettime-plus-oem-fixes into lp:~phablet-team/ofono/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 71228 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140716/9f3b1a1c/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list