[Merge] lp:~thomas-voss/trust-store/add_convenience_function_for_processing_incoming_requests into lp:trust-store

Marcus Tomlinson marcus.tomlinson at canonical.com
Wed Jul 16 11:49:30 UTC 2014


> 545     +    static const std::string& name()
> 
> const std::string? Should we not rather use static constexpr const char*?

Ah, I see this name() trait is somewhat of a standard amongst your projects. Sorry, ignore that one.
-- 
https://code.launchpad.net/~thomas-voss/trust-store/add_convenience_function_for_processing_incoming_requests/+merge/226696
Your team Ubuntu Phablet Team is subscribed to branch lp:trust-store.



More information about the Ubuntu-reviews mailing list