[Merge] lp:~ochosi/xdg-utils/support_xfce into lp:ubuntu/xdg-utils

[Didier Roche]

Review: Needs Fixing

for reference:
didrocks | ochosi: seems that you are doing an inline patch                                       
didrocks | would be better to add it as a patch                                                   
didrocks | also, I think you can break other use case with replacing '' by 'xfce'                 
  ochosi | no                                                                                     
didrocks | shouldn't you just append (before the '') the 'xfce' case?                             
  ochosi | the thing is, that there is a second ''                                                
  ochosi | i submitted another bug report about that                                              
  ochosi | ubuntu is carrying a useless patch, which duplicates code                              
didrocks | ah indeed                                                                              
  ochosi | so i thought i'd use that duplication to my advantage for now                          
didrocks | so yeah, the replacement is fine                                                       
  ochosi | simply to produce the most minimal patch                                               
  ochosi | to get SRU'd ;)                                                                        
didrocks | however, this should be carried as a patch, not an inline change?                      
  ochosi | sure, i'm fine with that                                                               
didrocks | ochosi: ok, just do that change and I'll +1 for utopic                                 
  ochosi | although after it's SRU'd I think it should be done properly                           
didrocks | ochosi: yeah, try to get it into debian/upstream to not have that as a patch :)        
  ochosi | i've gotten in touch with upstream, but after the initial reply i haven't heard back...
  ochosi | ofc :)                                                                                 
  ochosi | i know it's a bit silly                                                                
didrocks | but let's do it as a patch first to unblock your SRU                                   
  ochosi | yup, thanks!                                                                           
didrocks | yw, just ping me back :)                                                               
didrocks | (also provides a changelog with the bug ref and so on)                                 
  ochosi | ok, i haven't ever done a debian patch, but i'll give it a shot                        
       * | ochosi isn't a coder anyways...                                                        
didrocks | ochosi: poke me if you need any help, look for "quilt" ;)                              
didrocks | ochosi: https://wiki.debian.org/UsingQuilt                                             
       * | ochosi only understands "scotland"                                                     
didrocks | and http://packaging.ubuntu.com/html/patches-to-packages.html                          
didrocks | heh ;)                                                                                 

-- 
https://code.launchpad.net/~ochosi/xdg-utils/support_xfce/+merge/224076
Your team Ubuntu branches is subscribed to branch lp:ubuntu/xdg-utils.