[Merge] lp:~artmello/webbrowser-app/webbrowser-app-statesaver into lp:webbrowser-app

[Renato Araujo Oliveira Filho]

Diff comments:

> === modified file 'src/app/webbrowser/Browser.qml'
> --- src/app/webbrowser/Browser.qml	2014-07-09 16:36:42 +0000
> +++ src/app/webbrowser/Browser.qml	2014-07-11 12:53:14 +0000
> @@ -29,6 +29,14 @@
>      currentWebview: tabsModel.currentWebview
>  
>      property QtObject searchEngine
> +    property url currentUrl: currentWebview ? currentWebview.url : ""

What is currentWebview? Is that always created? 
could this property be alias like:  property alias currentUrl: currentWebview.url

> +    StateSaver.properties: "currentUrl"
> +
> +    Component.onCompleted: {

If the property is an alias you should not need that.

> +        if (currentUrl.toString() && currentWebview)
> +            if (currentUrl !== currentWebview.url)
> +                currentWebview.url = currentUrl;
> +    }
>  
>      actions: [
>          Actions.GoTo {
> 
> === modified file 'src/app/webbrowser/webbrowser-app.qml'
> --- src/app/webbrowser/webbrowser-app.qml	2014-06-30 10:40:59 +0000
> +++ src/app/webbrowser/webbrowser-app.qml	2014-07-11 12:53:14 +0000
> @@ -21,6 +21,8 @@
>  import Ubuntu.Components 0.1
>  
>  Window {
> +    id: webbrowserAppWindow
> +
>      property alias searchEngine: browser.searchEngine
>      property alias chromeless: browser.chromeless
>      property alias developerExtrasEnabled: browser.developerExtrasEnabled
> 


-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-statesaver/+merge/226447
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~artmello/webbrowser-app/webbrowser-app-statesaver into lp:webbrowser-app.