[Merge] lp:~abreu-alexandre/webbrowser-app/add-ap-tests-for-navigation-and-popup into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Thu Jul 10 06:12:16 UTC 2014
To get back (again, sorry…) on the WEBAPP_CONTAINER_AP_TESTS_NOT_FILTER_URL_PATTERNS environment variable mechanism, if I understand correctly you added this "backdoor" because UrlPatternUtils::transformWebappSearchPatternToSafePattern(…) doesn’t recognize patterns that contain a port number, right?
If this is correct, how hard (and desirable) would it be to update the method to recognize patterns that contain a port number? It sounds like this could be useful, as the port number is part of the URL specification, so there could be webapps with a well-known domain name that require it, e.g. https://mycoolwebapp.com:12345/.
--
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/add-ap-tests-for-navigation-and-popup/+merge/217811
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~abreu-alexandre/webbrowser-app/add-ap-tests-for-navigation-and-popup into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list