[Merge] lp:~brendan-donegan/qtubuntu-sensors/bug1337284 into lp:qtubuntu-sensors

Brendan Donegan brendan.donegan at canonical.com
Mon Jul 7 14:35:31 UTC 2014


Brendan Donegan has proposed merging lp:~brendan-donegan/qtubuntu-sensors/bug1337284 into lp:qtubuntu-sensors.

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~brendan-donegan/qtubuntu-sensors/bug1337284/+merge/225840

The values of m_lastX, m_lastY and m_lastZ were not being initialized on creation. This allowed some faulty values to get through and corrupt the logic of the function, meaning that sometimes a rotation event could be issued for no reason. This branch fixes that, and I've tested that in the scenario where the unexpected rotation would occur, it no longer does.

-- 
https://code.launchpad.net/~brendan-donegan/qtubuntu-sensors/bug1337284/+merge/225840
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~brendan-donegan/qtubuntu-sensors/bug1337284 into lp:qtubuntu-sensors.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 501 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140707/aca7b697/attachment.diff>


More information about the Ubuntu-reviews mailing list