[Merge] lp:~artmello/webbrowser-app/webbrowser-app-bookmarks_top_sites into lp:webbrowser-app

Arthur Mello arthur.mello at canonical.com
Fri Jul 4 12:58:58 UTC 2014


> 209     +    property int bookmarksCountLimit: 5
> 210     +    property bool seeMoreBookmarksView: false
> 
> It looks like those two properties don’t need to be exposed publicly, as
> they’re not being used anywhere outside the component. Can they be made
> private, by moving them to a QtObject instance with id 'private'?

Fixed on revision 588
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-bookmarks_top_sites/+merge/224592
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list