[Merge] lp:~sergiusens/nuntium/smil_fix into lp:nuntium

Manuel de la Peña manuel.delapena at canonical.com
Wed Jul 2 08:30:04 UTC 2014


Review: Needs Fixing



Diff comments:

> === modified file 'mms/attachments.go'
> --- mms/attachments.go	2014-07-01 12:36:01 +0000
> +++ mms/attachments.go	2014-07-01 12:36:01 +0000
> @@ -103,11 +103,11 @@
>  //GetSmil returns the text corresponding to the ContentType that holds the SMIL
>  func (pdu *MRetrieveConf) GetSmil() (string, error) {
>  	for i := range pdu.Attachments {
> -		if pdu.Attachments[i].MediaType == "application/smil" {
> +		if strings.HasPrefix(pdu.Attachments[i].MediaType, "application/smil") {

HasPrefix or Contains?? Is there an example of a smil media type that is not exactly "application/smil"?

>  			return string(pdu.Attachments[i].Data), nil
>  		}
>  	}
> -	return "", errors.New("Cannot find SMIL data part")
> +	return "", errors.New("cannot find SMIL data part")
>  }
>  
>  //GetDataParts returns the non SMIL ContentType data parts
> 


-- 
https://code.launchpad.net/~sergiusens/nuntium/smil_fix/+merge/225153
Your team Ubuntu Phablet Team is subscribed to branch lp:nuntium.



More information about the Ubuntu-reviews mailing list