[Merge] lp:~michael-sheldon/webbrowser-app/general-download-support into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Jul 1 18:04:22 UTC 2014


315	+                headers["Referer"] = request.referrer

It seems "referer" is a common mispelling of "referrer", would that be a bug/typo in UDM?


317	+            headers["User-Agent"] = webview.context.userAgent

This won’t get us the overridden UA if any, it’s probably good enough in most cases but I would bet some corner cases will fail because the download is not requested with the same UA as the one that was used to request the parent page.
-- 
https://code.launchpad.net/~michael-sheldon/webbrowser-app/general-download-support/+merge/225143
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~michael-sheldon/webbrowser-app/general-download-support into lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list