[Merge] lp:~aacid/kubuntu-packaging/qtbase-opensource-src into lp:~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src

[Albert Astals Cid]

Albert Astals Cid has proposed merging lp:~aacid/kubuntu-packaging/qtbase-opensource-src into lp:~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src.

Commit message:
Fix crash on dbus shutdown

Already accepted upstream at https://codereview.qt-project.org/#/c/86825/

Requested reviews:
  Kubuntu Packagers (kubuntu-packagers)
Related bugs:
  Bug #1332598 in Unity 8: "make testShell crashes"
  https://bugs.launchpad.net/unity8/+bug/1332598

For more details, see:
https://code.launchpad.net/~aacid/kubuntu-packaging/qtbase-opensource-src/+merge/225134

Without it i get 

==20075== Invalid read of size 4
==20075==    at 0x1194E793: QList<QString>::~QList() (in /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.3.0)
==20075==    by 0x11961BD9: QHash<QString, QDBusConnectionPrivate::SignalHook>::deleteNode2(QHashData::Node*) (in /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.3.0)
==20075==    by 0x6445A68: QHashData::free_helper(void (*)(QHashData::Node*)) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.3.0)
==20075==    by 0x1195861C: QDBusConnectionPrivate::~QDBusConnectionPrivate() (in /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.3.0)
==20075==    by 0x11958938: QDBusConnectionPrivate::~QDBusConnectionPrivate() (in /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.3.0)
==20075==    by 0x1194CEF5: (anonymous namespace)::Q_QGS__q_systemBus::innerFunction()::Holder::~Holder() (in /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.3.0)
==20075==    by 0x5090988: __run_exit_handlers (exit.c:82)
==20075==    by 0x50909D4: exit (exit.c:104)
==20075==    by 0x5077ECB: (below main) (libc-start.c:321)
==20075==  Address 0x2821a4e0 is not stack'd, malloc'd or (recently) free'd
==20075== 
==20075== 
==20075== Process terminating with default action of signal 11 (SIGSEGV)
==20075==  Access not within mapped region at address 0x2821A4E0
==20075==    at 0x1194E793: QList<QString>::~QList() (in /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.3.0)
==20075==    by 0x11961BD9: QHash<QString, QDBusConnectionPrivate::SignalHook>::deleteNode2(QHashData::Node*) (in /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.3.0)
==20075==    by 0x6445A68: QHashData::free_helper(void (*)(QHashData::Node*)) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.3.0)
==20075==    by 0x1195861C: QDBusConnectionPrivate::~QDBusConnectionPrivate() (in /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.3.0)
==20075==    by 0x11958938: QDBusConnectionPrivate::~QDBusConnectionPrivate() (in /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.3.0)
==20075==    by 0x1194CEF5: (anonymous namespace)::Q_QGS__q_systemBus::innerFunction()::Holder::~Holder() (in /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5.3.0)
==20075==    by 0x5090988: __run_exit_handlers (exit.c:82)
==20075==    by 0x50909D4: exit (exit.c:104)
==20075==    by 0x5077ECB: (below main) (libc-start.c:321)

on unity8's make testShell shutdown
-- 
https://code.launchpad.net/~aacid/kubuntu-packaging/qtbase-opensource-src/+merge/225134
Your team Kubuntu Packagers is requested to review the proposed merge of lp:~aacid/kubuntu-packaging/qtbase-opensource-src into lp:~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2384 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140701/9358ff75/attachment.diff>