[Merge] lp:~kai-mast/friends/facebook-link-picture-size into lp:friends
Robert Bruce Park
robert.park at canonical.com
Tue Jan 28 21:47:40 UTC 2014
Review: Needs Fixing
Looks mostly good, but here's some improvements you can make:
if (message_id is None) or (message_type is None):
should be:
if None in (message_id, message_type):
and then:
if to and not (to is ""):
Not sure what you're even trying to do here. if "to" is an empty string, it will evaluate false in python. So this is already equivalent:
if to:
then:
place = entry.get('place') or {}
location = place.get('location') or {}
should be:
place = entry.get('place', {})
location = place.get('location', {})
and:
if not (picture_url is ''):
can be:
if picture_url:
--
https://code.launchpad.net/~kai-mast/friends/facebook-link-picture-size/+merge/203629
Your team Super Friends is subscribed to branch lp:friends.
More information about the Ubuntu-reviews
mailing list