[Merge] lp:~kai-mast/friends-app/leaks into lp:friends-app

Kai Mast mail at kai-mast.de
Tue Jan 28 10:17:26 UTC 2014


Kai Mast has proposed merging lp:~kai-mast/friends-app/leaks into lp:friends-app.

Requested reviews:
  Super Friends (super-friends)

For more details, see:
https://code.launchpad.net/~kai-mast/friends-app/leaks/+merge/203499

This branch fixes/disables a warning when friends-app is built (not sure if this function is even still needed though).

Also m_view was overwritten by a local variable, so there could be a memory leak. 

Finally, I did some cleanup of the coding style and removed the nullpointer check (delete nullptr; is a valid operation in C++, you don't have to check explicitly). 
-- 
https://code.launchpad.net/~kai-mast/friends-app/leaks/+merge/203499
Your team Super Friends is requested to review the proposed merge of lp:~kai-mast/friends-app/leaks into lp:friends-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3011 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140128/61d15420/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list