[Merge] lp:~lihow731/ubuntu/saucy/gnome-calculator/fix-for-1209326 into lp:ubuntu/saucy/gnome-calculator

[Jamie Strandboge]

Review: Needs Fixing

Thanks for your patch! A few comments:
 * your merge request was made with patches applied. This includes the .pc directory and code changes. Since you are adding a patch to debian/patches, it is easier for reviewers if you 'quilt pop -a' before submitting the request. You might find when working on SRUs it is easier to provide a debdiff in the bug
 * in debian/changelog, 1:3.8.2-1ubuntu5ppa should be 1:3.8.2-1ubuntu4.1
 * in debian/changelog, saucy should be 'saucy-proposed'
 * debian/patches/fix-the-undo-ctrl-z-bug.patch has a lot of information, but it isn't quite right. It should focus on upstream commits (if appropriate) and reference the Ubuntu bug. Eg:
Origin: <upstream commit>
Description: Fix the undo/ctrl-z bug
 Due to the code structure, the undo stack do not keep the last answer.
 We use another variable to keep it.
Bug-Ubuntu: https://launchpad.net/bugs/1209326

If there is no upstream commit, you should use 'Author: Person Who <authored at the.patch>'. The DEP-3 comments that are in your patch were unclear, especially in light of the boiler text that was included.
-- 
https://code.launchpad.net/~lihow731/ubuntu/saucy/gnome-calculator/fix-for-1209326/+merge/202198
Your team Ubuntu branches is subscribed to branch lp:ubuntu/saucy/gnome-calculator.