[Merge] lp:~noskcaj/ubuntu/trusty/enblend-enfuse/merge into lp:ubuntu/enblend-enfuse
Dmitry Shachnev
mitya57 at gmail.com
Fri Jan 24 11:39:28 UTC 2014
Review: Needs Fixing
Using DEB_*FLAGS_MAINT_APPEND this way is wrong. By default Debian flags already contain -g and -O2, so:
1) adding -g is unneeded;
2) if you want to append -OX when X≠2, you need also to DEB_*FLAGS_MAINT_STRIP -O2;
3) dpkg-buildflags takes care of DEB_BUILD_OPTIONS=noopt itself, no need to append anything in that case.
Also, did you really try to build the package? Lines like "export DEB_CXXFLAGS_MAINT_APPEND -O0" (without "=" sign) look like syntax error to me.
Please submit a clean MP with those issues fixed.
--
https://code.launchpad.net/~noskcaj/ubuntu/trusty/enblend-enfuse/merge/+merge/202544
Your team Ubuntu branches is subscribed to branch lp:ubuntu/enblend-enfuse.
More information about the Ubuntu-reviews
mailing list