[Merge] lp:~jamesodhunt/ubuntu/trusty/upstart/periodic-logrotate into lp:ubuntu/upstart

James Hunt james.hunt at canonical.com
Tue Jan 21 11:12:28 UTC 2014


James Hunt has proposed merging lp:~jamesodhunt/ubuntu/trusty/upstart/periodic-logrotate into lp:ubuntu/upstart.

Requested reviews:
  Steve Langasek (vorlon)

For more details, see:
https://code.launchpad.net/~jamesodhunt/ubuntu/trusty/upstart/periodic-logrotate/+merge/202434

We already provide a logrotate session job which runs soon after the user session has been created. However, it is never re-run.

It seems sensible that, like its /etc/cron.daily/logrotate system counterpart we run this job periodically to keep session jobs logs compacted. This would help with for example bug 1269838 (although may admittedly mask the issue to some degree). By creating this new job to handle the periodicity, it is easy for a user to modify the period:

    # change period to 5 minutes
    echo 'env ROTATE_SECONDS=300' >> ~/.config/upstart/periodic-logrotate.override

We could encapsulate all this within the logrotate job itself but 2 jobs allows the existing behaviour to be retained should that be desirable by simply disabling the new job:

   echo manual >> ~/.config/upstart/periodic-logrotate.override


-- 
https://code.launchpad.net/~jamesodhunt/ubuntu/trusty/upstart/periodic-logrotate/+merge/202434
Your team Ubuntu branches is subscribed to branch lp:ubuntu/upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1129 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140121/de71bb8e/attachment.diff>


More information about the Ubuntu-reviews mailing list