[Merge] lp:~geoubuntu/ubuntu/trusty/tvtime/1265576+1265577 into lp:ubuntu/tvtime

[POJAR GEO]

POJAR GEO has proposed merging lp:~geoubuntu/ubuntu/trusty/tvtime/1265576+1265577 into lp:ubuntu/tvtime.

Requested reviews:
  Ubuntu branches (ubuntu-branches)
Related bugs:
  Bug #1265576 in tvtime (Ubuntu): "Link to libsupc++ instead of bringing in libstdc++."
  https://bugs.launchpad.net/ubuntu/+source/tvtime/+bug/1265576
  Bug #1265577 in tvtime (Ubuntu): "Add support to the _NET_WM_PID atom"
  https://bugs.launchpad.net/ubuntu/+source/tvtime/+bug/1265577

For more details, see:
https://code.launchpad.net/~geoubuntu/ubuntu/trusty/tvtime/1265576+1265577/+merge/200331

1. Link to libsupc++ instead of bringing in libstdc++ just because tomsocomp is written in C++. It does not use STL so it needs not the whole standard library.

2. Add support to the _NET_WM_PID atom which is needed by many windows managers to correctly associate a SDL window to its process and to related .desktop file and icon for the given host.

   EWMH (Extended Window Manager Hints) is a set of conventions (basically extending the original ICCCM, or Inter-Client Communication Conventions Manual) on how to make X clients play along nicely especially assisting the window manager (which is just another X client) do its job.

   What this particular protocol (_NET_WM_PID) does, is add a property to the client's window containing the process id of the client's process. The rationale is that if the window manager detects that a particular client does not respond, it can use the pid to kill it.

  Tested with: xprop _NET_WM_PID

3. Fix another memory leak discovered by the cppcheck tool

4. Renamed debian/patches/tvtime-1.0.2-icon.patch to tvtime-1.0.2-wmicon.patch for clarity.
-- 
https://code.launchpad.net/~geoubuntu/ubuntu/trusty/tvtime/1265576+1265577/+merge/200331
Your team Ubuntu branches is requested to review the proposed merge of lp:~geoubuntu/ubuntu/trusty/tvtime/1265576+1265577 into lp:ubuntu/tvtime.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 20406 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140102/36413d0a/attachment-0001.diff>