[Merge] lp:~allanlesage/kubuntu-packaging/qt3d-enable-tests into lp:~kubuntu-packagers/kubuntu-packaging/qt3d-opensource-src

Dmitry Shachnev mitya57 at gmail.com
Wed Jan 1 07:24:47 UTC 2014


Review: Needs Fixing

Thanks for your work here. We usually prefer when:

- tests are built in build target, not in override_dh_auto_test (i.e. use QT_BUILD_PARTS+=tests);
- you actually use dh_auto_test (i.e. 'dh_auto_test -- -C tests/auto/' is a much simplier command than yours);
- and if dh_auto_test for some reason doesn't work for you, make sure DEB_BUILD_OPTIONS=nocheck is honored.

Check qtsvg-opensource-src for an example of a good implementation.
-- 
https://code.launchpad.net/~allanlesage/kubuntu-packaging/qt3d-enable-tests/+merge/199875
Your team Kubuntu Packagers is subscribed to branch lp:~kubuntu-packagers/kubuntu-packaging/qt3d-opensource-src.



More information about the Ubuntu-reviews mailing list