[Merge] lp:~psusi/ubuntu/trusty/udisks2/fix-standby into lp:ubuntu/udisks2

Martin Pitt martin.pitt at ubuntu.com
Wed Feb 26 10:21:27 UTC 2014


Review: Needs Information

I replied to devkit-devel@, but copying response here as well:

I came across the AT Attachment 8 - ATA/ATAPI Command Set draft at e. g.
http://www.t10.org/t13/docs2005/D1699r1b-ATA8-ACS.pdf, and that only describes
E3h, "The IDLE command allows the host to place the device in the Idle mode and
also set the Standby timer.", which seems to be what we actually want here. E2h
says "This command causes the device to enter the Standby mode." which sounds
like "immediate".

The "ata-pm-standby" property is only defined to specify the timeout, setting
the timeout should not put the file into immediate standby.

So it seems to me that the current code is right, and this patch would
change the behaviour to an unintended one?

-- 
https://code.launchpad.net/~psusi/ubuntu/trusty/udisks2/fix-standby/+merge/206951
Your team Ubuntu branches is requested to review the proposed merge of lp:~psusi/ubuntu/trusty/udisks2/fix-standby into lp:ubuntu/udisks2.



More information about the Ubuntu-reviews mailing list