[Merge] lp:~psivaa/ubuntu-test-cases/mod_php-fix into lp:ubuntu-test-cases/server

Robie Basak robie.basak at canonical.com
Tue Feb 25 11:09:17 UTC 2014


Review: Approve

This is certainly no worse than it was before. Please also change the comment from 7 to 5 - otherwise the comment will mismatch the code.

A suggest for improvement here (but I don't wish for this to block merging this branch now): I'd say that we should check the return value of the mysql command, since that is the conventional programmatic way for it to declare that there was a problem. subprocess.Popen provides a mechanism to do this.
-- 
https://code.launchpad.net/~psivaa/ubuntu-test-cases/mod_php-fix/+merge/204273
Your team Ubuntu Server Developers is subscribed to branch lp:ubuntu-test-cases/server.



More information about the Ubuntu-reviews mailing list