[Merge] lp:~ssweeny/friends-app/lp1261438 into lp:friends-app

Scott Sweeny scott.sweeny at canonical.com
Mon Feb 17 05:52:24 UTC 2014


Scott Sweeny has proposed merging lp:~ssweeny/friends-app/lp1261438 into lp:friends-app.

Commit message:
Remove iconSource definition from accountDelegate

According to [1] if both iconName and iconSource are defined iconName is ignored. Also, iconSource was apparently not being defined correctly which resulted in no icons being shown in the post screen anyway.

[1] http://developer.ubuntu.com/api/qml/sdk-14.04/Ubuntu.Components.ListItems.Standard/#iconName-prop


Requested reviews:
  Super Friends (super-friends)
Related bugs:
  Bug #1261438 in friends-app (Ubuntu): "No protocol icons in Post View"
  https://bugs.launchpad.net/ubuntu/+source/friends-app/+bug/1261438

For more details, see:
https://code.launchpad.net/~ssweeny/friends-app/lp1261438/+merge/206656

Remove iconSource definition from accountDelegate

According to [1] if both iconName and iconSource are defined iconName is ignored. Also, iconSource was apparently not being defined correctly which resulted in no icons being shown in the post screen anyway.

[1] http://developer.ubuntu.com/api/qml/sdk-14.04/Ubuntu.Components.ListItems.Standard/#iconName-prop

-- 
https://code.launchpad.net/~ssweeny/friends-app/lp1261438/+merge/206656
Your team Super Friends is requested to review the proposed merge of lp:~ssweeny/friends-app/lp1261438 into lp:friends-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 428 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140217/0b45b63e/attachment.diff>


More information about the Ubuntu-reviews mailing list