[Merge] lp:~edwinpm5/ubuntu/trusty/gnome-screenshot/discard-button-and-alignment into lp:ubuntu/gnome-screenshot
Edwin Pujols
edwinpm5 at gmail.com
Fri Feb 14 04:58:59 UTC 2014
I just read the git history of the upstream source (GNOME). It says:
> commit fca6036f4642612fe649b04ebe839766c644fdbf
> Author: Cosimo Cecchi <cosimoc at gnome.org>
> Date: Tue May 8 14:23:44 2012 -0400
>
> screenshot: add an application menu for the interactive window
>
> When started in interactive mode, the tool should behave as a real
> GNOME app, and use an application menu.
> This also allows us to remove the Help button from there, and move it to
> the application menu.
> Finally, the toplevel window is now a regular GtkApplicationWindow (not
> a GtkDialog), so it gained a real "Close" button we can use instead of
> the "Cancel" one we had before.
>
> https://bugzilla.gnome.org/show_bug.cgi?id=674947
So GNOME removed the Cancel button for design reasons, I guess there's not much point in taking this patch there. The Cancel button stuff is kind of desktop specific (Xfce and KDE got their own screenshot utils, IRC), so Debian wouldn't be too interested either: GNOME maintainers might want to stay close to GNOME's HIG, and for other DE's and WM's the close button is enough.
Nonetheless, I guess I'll try to at least send the alignment of the labels stuff to GNOME.
--
https://code.launchpad.net/~edwinpm5/ubuntu/trusty/gnome-screenshot/discard-button-and-alignment/+merge/206321
Your team Ubuntu branches is requested to review the proposed merge of lp:~edwinpm5/ubuntu/trusty/gnome-screenshot/discard-button-and-alignment into lp:ubuntu/gnome-screenshot.
More information about the Ubuntu-reviews
mailing list