[Merge] lp:~louis-bouchard/ubuntu/trusty/clamav/lp799623_fix_logrotate into lp:ubuntu/clamav
Louis Bouchard
louis.bouchard at canonical.com
Wed Feb 12 15:50:30 UTC 2014
Before I go any further, the addition of [[:space:]] was to discriminate on word boundary. When the CLAMAVCONF file has entries like this :
StreamMaxLength 25M
LogFileMaxSize 0
LogFile /var/log/clamav/clamav.log
the grep could not discriminate b/w LogFileMaxSize & LogFile, so the LogFile variable ended up with 0.
Revisiting the expression, I think that using \b would be more appropriate to discriminate on word boudaries so the expression would be :
value=`grep "^$variable\b" $CLAMAVCONF | head -n1 | awk '{print $2}'`
Unless you see an issue with this, I will go ahead with that fix, since the [[:space:]] was not intended to identify single space, but word boundaries
--
https://code.launchpad.net/~louis-bouchard/ubuntu/trusty/clamav/lp799623_fix_logrotate/+merge/205627
Your team Ubuntu branches is subscribed to branch lp:ubuntu/clamav.
More information about the Ubuntu-reviews
mailing list