[Merge] lp:~louis-bouchard/ubuntu/trusty/clamav/lp799623_fix_logrotate into lp:ubuntu/clamav

Martin Pitt martin.pitt at ubuntu.com
Wed Feb 12 15:12:52 UTC 2014


Review: Needs Fixing

This looks like it could easily introduce a regression, especially on config files which look "normal", i. e. only use one space to separate words. Are you sure that instead of 

  value=`grep ^$variable[[:space:]] $CLAMAVCONF | head -n1 | awk '{print $2}'`

you don't mean

  value=`grep ^$variable[[:space:]]* $CLAMAVCONF | head -n1 | awk '{print $2}'`

?
-- 
https://code.launchpad.net/~louis-bouchard/ubuntu/trusty/clamav/lp799623_fix_logrotate/+merge/205627
Your team Ubuntu branches is subscribed to branch lp:ubuntu/clamav.



More information about the Ubuntu-reviews mailing list