[Merge] lp:~geoubuntu/ubuntu/trusty/tvtime/alsa into lp:ubuntu/tvtime

Iain Lane iain at orangesquash.org.uk
Tue Feb 11 12:18:32 UTC 2014


This package has far too much patching. IMO it's inappropriate to be doing this level of changes downstream.

Why don't you fork the package properly and then introduce /that/ in Ubuntu?

Before this branch, the Debian patches were:

   59 files changed, 2670 insertions(+), 838 deletions(-)

& after it:

   64 files changed, 3840 insertions(+), 872 deletions(-)

Don't get me wrong, I'm really happy that you are working on tvtime now; I just think it'd be better to do this as an upstream rather than through Ubuntu patches. It'd even be possible to drop `tvtime' from Ubuntu and replace it with your fork.
-- 
https://code.launchpad.net/~geoubuntu/ubuntu/trusty/tvtime/alsa/+merge/204145
Your team Ubuntu branches is requested to review the proposed merge of lp:~geoubuntu/ubuntu/trusty/tvtime/alsa into lp:ubuntu/tvtime.



More information about the Ubuntu-reviews mailing list