[Merge] lp:~matttbe/ubuntu/trusty/nautilus/lp1277963 into lp:ubuntu/nautilus

[Matthieu Baerts]

Matthieu Baerts has proposed merging lp:~matttbe/ubuntu/trusty/nautilus/lp1277963 into lp:ubuntu/nautilus.

Requested reviews:
  Ubuntu Desktop (ubuntu-desktop)
Related bugs:
  Bug #1277963 in nautilus (Ubuntu): "ubuntu_show_titlebar.patch: XDG_CURRENT_DESKTOP is not correctly compared with GNOME"
  https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1277963

For more details, see:
https://code.launchpad.net/~matttbe/ubuntu/trusty/nautilus/lp1277963/+merge/205489

Hello,

Currently in ubuntu_show_titlebar.patch, 'g_strcmp0' function is used but the result is not compared to 0.

According to the GLib Reference Manual: just like "strcmp", this function returns an integer less than, equal to, or greater than zero, if str1 is <, == or > than str2.

See Bug #1277963
-- 
https://code.launchpad.net/~matttbe/ubuntu/trusty/nautilus/lp1277963/+merge/205489
Your team Ubuntu branches is subscribed to branch lp:ubuntu/nautilus.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4409 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20140208/b379e570/attachment.diff>