[Merge] lp:~canonical-platform-qa/webbrowser-app/autopilot-address_bar-textfield into lp:webbrowser-app

Leo Arias leo.arias at canonical.com
Wed Dec 17 23:28:17 UTC 2014


> Same remark as above for the following snippets:
> 
> 529     +        self.address_bar.clear()
> 530     +        self.address_bar.write('ubuntu')
> 
> 
> 577     +        self.address_bar.clear()
> 578     +        self.address_bar.write('(phil')

As you were testing there the behaviour of the suggestions, I thought it would be better to make it explicit when we are clearing the address bar.  When we call clear and there is nothing in the textfield, it does nothing; so we would be just duplicating one if, and no finger or mouse actions.

If you prefer, I can remove the calls to clear and use the keyword clear=True. Let me know if that seems better to you.
-- 
https://code.launchpad.net/~canonical-platform-qa/webbrowser-app/autopilot-address_bar-textfield/+merge/244663
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list