[Merge] lp:~abreu-alexandre/webbrowser-app/user-agent-override-fails into lp:webbrowser-app

Alexandre Abreu alexandre.abreu at canonical.com
Tue Dec 2 17:17:53 UTC 2014


> 29      +             * The default mechanism that allows a webview
> 30      +             * to set its UA (getUAString) has a race if the webview
> 31      +             * URL is set at webview & context construction. Oxide
> 32      +             * starts its http requests for the URL w/ the initial UA
> 33      +             * NOT the one that is "delay gathered" after the
> component
> 34      +             * has been constructed through the getUAString() call.
> 
> How about we try to fix that race at the source, instead of working around it
> in the container?
> (this is fine as a temporary solution, but indeed this getUAString() function
> is not really a good idea and it should be fixed)

Yes, I agree, this is only a way to mitigate and fix the issue right now. I did
not want to get into a redesign for (which involves an API change) for now; only
part of a second step ...


-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/user-agent-override-fails/+merge/243286
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list